Remove support for bsconfig.json #8187
Merged
+34
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes support for the deprecated bsconfig.json configuration file across the entire ReScript toolchain. Going forward, only rescript.json will be supported as the project configuration file.
Changes:
- Removed all fallback logic that checked for
bsconfig.jsonwhenrescript.jsonis not found - Updated error messages, documentation, and comments to reference only
rescript.json - Removed literal constants and variables referencing
bsconfig.jsonfrom the codebase
Reviewed changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/bin/main.ml | Updated error message to only mention rescript.json |
| tests/tests/src/test_literals.res | Removed bsconfig_json literal constant |
| tests/tests/src/test_literals.mjs | Removed bsconfig_json export |
| tests/build_tests/warn_legacy_config/input.js | Updated test assertion to match new error message |
| rewatch/tests/suite.sh | Added workaround to copy bsconfig.json to rescript.json for external dependency |
| rewatch/src/helpers.rs | Removed bsconfig.json check from config detection |
| rewatch/src/config.rs | Updated comments from bsconfig to rescript.json or generic config |
| rewatch/src/build/packages.rs | Simplified config reading to only check for rescript.json |
| rewatch/MonorepoSupport.md | Removed references to legacy bsconfig.json in documentation |
| rewatch/CompilerConfigurationSpec.md | Updated documentation to use generic "config" terminology |
| compiler/gentype/Paths.ml | Removed fallback to legacy config file |
| compiler/gentype/GenTypeConfig.ml | Removed legacy config file constant and fallback logic |
| compiler/frontend/ast_config.ml | Renamed functions from bs_config to config |
| compiler/ext/literals.ml | Removed bsconfig_json literal constant |
| compiler/ext/ext_path.ml | Updated find_config_dir to only search for rescript.json |
| analysis/src/Packages.ml | Removed bsconfig.json fallback logic |
| analysis/src/FindFiles.ml | Removed bsconfig.json fallback when reading dependency configs |
| analysis/reanalyze/src/ReanalyzeServer.ml | Updated comment to only mention rescript.json |
| analysis/reanalyze/src/Reanalyze.ml | Updated comment and renamed function from processBsconfig to processConfig |
| analysis/reanalyze/src/Paths.ml | Removed bsconfig constant and fallback logic |
| CHANGELOG.md | Added breaking change entry for removing bsconfig.json support |
| .github/workflows/ci.yml | Removed separate testrepo install step (now handled in test suite) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nojaf
approved these changes
Jan 18, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes support for the deprecated
bsconfig.json. Going forward, onlyrescript.jsonwill be supported.